Add traffic management module to the python libraries#890
Draft
h3lix1 wants to merge 2 commits intomeshtastic:masterfrom
Draft
Add traffic management module to the python libraries#890h3lix1 wants to merge 2 commits intomeshtastic:masterfrom
h3lix1 wants to merge 2 commits intomeshtastic:masterfrom
Conversation
Contributor
|
This all seems reasonable to me; assuming the protobuf and firmware changes also get merged, would you mind pinging me to get back to this whenever it's ready to go out of draft? I'm |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #890 +/- ##
==========================================
- Coverage 59.82% 59.79% -0.04%
==========================================
Files 24 24
Lines 4329 4333 +4
==========================================
+ Hits 2590 2591 +1
- Misses 1739 1742 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding traffic_management to be part of the configuration options when using --set and --get.
This relates to meshtastic/protobufs#849 and can't be pushed until the protobufs are complete.
Placing this in draft for now.